-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Cut v2.10.0 #2176
chore: Cut v2.10.0 #2176
Conversation
This issue is currently awaiting triage. If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
a321e45
to
155214d
Compare
* Add support for endpoint topology routing hints Fix goimports Fix gocritic issue * Update docs/endpointslice-metrics.md Co-authored-by: Manuel Rüger <manuel@rueg.eu> * Update internal/store/endpointslice.go Co-authored-by: Manuel Rüger <manuel@rueg.eu> * Update Dockerfile * Update Dockerfile * Update endpointslice_test.go * Redesign metric * Update endpointslice.go Remove unneeded label * Update endpointslice.go * Update endpointslice-metrics.md * Fix test * Remove hostname * Update docs/endpointslice-metrics.md --------- Co-authored-by: Manuel Rüger <manuel@rueg.eu> Co-authored-by: Damien Grisonnet <damien.grisonnet@epita.fr>
Co-authored-by: Damien Grisonnet <damien.grisonnet@epita.fr> Signed-off-by: Manuel Rüger <manuel@rueg.eu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgrisonnet, mrueg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):